Remove ConsoleLogger #1449
Merged
Remove ConsoleLogger #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because once we merge this PR, we don't ship our own psr/log implementation anymore. Thus, we don't need to have an opinion on which psr/log version is installed. |
derrabus
force-pushed
the
remove/console-logger
branch
from
8152164 to
2700819
Compare
|
OK, but you'd still keep the native type declarations, right? |
My plan is that we don't implement that interface ourselves at all. See #1450 for the remaining implementations. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@internal)Summary
We don't need to maintain our own version of the
ConsoleLoggerclass. Symfony already has one, so let's use that. This will also allow us to revert #1446.