Skip to content

Commit

Permalink
Update logging to use Rust tracing_subscriber and
Browse files Browse the repository at this point in the history
avoid Python logger for Rust components.
  • Loading branch information
dnnanuti committed Mar 13, 2024
1 parent cbf5c4c commit 6309cf0
Show file tree
Hide file tree
Showing 7 changed files with 249 additions and 122 deletions.
17 changes: 12 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
## Unreleased

### New features

### Breaking changes
* Separate completely Rust logs and Python logs. Rust logs are configured through RUST_LOG,
S3_CONNECTOR_ENABLE_CRT_LOGS and S3_CONNECTOR_LOGS_DIR_PATH environment variables.


## v1.2.0 (March 13, 2024)

### New features
Expand All @@ -11,6 +20,7 @@
### Breaking changes
* No breaking changes.


## v1.1.4 (February 26, 2024)

### New features
Expand All @@ -37,7 +47,6 @@
* No breaking changes.



## v1.1.2 (January 19, 2024)

### New features
Expand All @@ -48,7 +57,6 @@
* No breaking changes.



## v1.1.1 (December 11, 2023)

### New features
Expand All @@ -69,13 +77,12 @@
* No breaking changes.



## v1.0.0 (November 22, 2023)
* The Amazon S3 Connector for PyTorch delivers high throughput for PyTorch training jobs that access and store data in Amazon S3.

### New features
* S3IterableDataset and S3MapDataset, which allow building either an iterable-style or map-style dataset, using your S3
stored data, by specifying an S3 URI (a bucket and optional prefix) and the region the bucket is in.
* S3IterableDataset and S3MapDataset, which allow building either an iterable-style or map-style dataset, using your S3
stored data, by specifying an S3 URI (a bucket and optional prefix) and the region the bucket is in.
* Support for multiprocess data loading for the above datasets.
* S3Checkpoint, an interface for saving and loading model checkpoints directly to and from an S3 bucket.

Expand Down
71 changes: 39 additions & 32 deletions s3torchconnectorclient/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions s3torchconnectorclient/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ built = "0.7"
pyo3 = { version = "0.19.2" }
pyo3-log = "0.8.3"
futures = "0.3.28"
mountpoint-s3-client = { version = "0.7.0", features = ["mock"] }
mountpoint-s3-crt = "0.6.1"
mountpoint-s3-client = { version = "0.8.0", features = ["mock"] }
mountpoint-s3-crt = "0.6.2"
log = "0.4.20"
tracing = { version = "0.1.40", default-features = false, features = ["std", "log"] }
tracing-subscriber = { version = "0.3.18", features = ["fmt", "env-filter"]}
Expand Down
Loading

0 comments on commit 6309cf0

Please sign in to comment.