Improve support for static arrays and non-CTFEable opEquals #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #30 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.x.x #50 +/- ##
==========================================
+ Coverage 84.63% 85.87% +1.24%
==========================================
Files 5 5
Lines 397 432 +35
==========================================
+ Hits 336 371 +35
Misses 61 61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The original intent of this commit was to avoid calling `opEquals` on types that we were evaluating for optionality, as a simple `is` comparison is enough. However, `is` was not used previously because it triggers a deprecation in D: Doing `a is b` when `a` and `b` are static array would compare their `.ptr`. Re-writing `isOptional` and adding test yield some issues with static array support, including compilation error. This is now working and the library will throw a proper error if the length do not match.
Geod24
force-pushed
the
mlang/StaticArray
branch
from
9675c00 to
c9e734c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intent of this commit was to avoid calling
opEqualson types that we were evaluating for optionality, as a simpleiscomparison is enough. However,iswas not used previously because it triggers a deprecation in D: Doinga is bwhenaandbare static array would compare their.ptr.Re-writing
isOptionaland adding test yield some issues with static array support, including compilation error. This is now working and the library will throw a proper error if the length do not match.