New function to implement Data -> String fastpath #1
Conversation
| @@ -129,10 +151,26 @@ func makeStringB(data: Data) -> String { | |||
| } ?? "" | |||
| } | |||
|
|
|||
| func dataToString(data: Data) -> String { | |||
| let holder = Holder(data: data) | |||
There was a problem hiding this comment.
Need to either add a condition here that only goes down this path if the Data's encoding is ASCII / UTF8 (similar to Philippe's code). The condition might belong in here, or rename this function to indicate that it is specifically an ASCII fastpath.
| // Block to be scheduled | ||
| func code(block: Int, loops: Int) -> () -> Void { | ||
| return { | ||
| var string: String? | ||
| var nsstring: NSString? |
There was a problem hiding this comment.
can you remove this (unused) ref + the commented block? I suspect method 0 is also not required.
There was a problem hiding this comment.
Couple of naming / cleanup comments to address.
Also, I think it would be useful to test this code converting Data from a variety of different encodings to check that they are correctly converted. It may be that plumbing this into Foundation and then running the tests would be sufficient - we'd need to see whether the existing tests cover conversion between different encodings.
Created new class which holds reference to a pointer This is so object can be passed to StringCore when it is created and acts as its owner and ensures memory is cleaned up appropriately. This behaviour might be possible using other core Swift classes, but hasn't been fully investigated.