Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Typos, Improve MongoDB/Redis Setup, and Update README #448

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix Typos, Improve MongoDB/Redis Setup, and Update README #448

wants to merge 5 commits into from
+154 −127

Conversation

AshokShau
Copy link
Contributor

  • add how to deploy on VPS
  • improve connect with Redis and MongoDB
  • typo's
  • bump deps

@AshokShau
nil but ...
328b69a 
* add how to deploy on VPS
* improve connect with Redis and MongoDB
* typo's
@AshokShau
'NewClient' is deprecated
84a02b4
@AshokShau
typos & use %q instead of "%s" for quoted strings
ebd5621
@AshokShau
Revert
66e91a7
@Divkix
Copy link
Member

Divkix commented Jan 9, 2025

Can you update the change and also a description as to what and why you did?

@AshokShau
Copy link
Contributor Author

AshokShau commented Jan 9, 2025 •
edited
Loading

Can you update the change and also a description as to what and why you did?

Thanks for your response!
"Update and change" - Could you clarify what updates or changes you'd like me to make

Here’s what I did:

  • Fixed typos, like moving the alt attribute from <a> to <img> for proper HTML.
  • Updated MongoDB usage: replaced deprecated NewClient with mongo.Connect and removed repetitive calls by using a variable for the database.
  • Improved error handling: switched to errors.Is for better error comparison.
  • Simplified Redis setup: replaced redis.NewClient with redis.ParseURL.
  • Updated the README with VPS deployment instructions."

@AshokShau AshokShau changed the title Improve Fix Typos, Improve MongoDB/Redis Setup, and Update README Jan 9, 2025
@Divkix
Copy link
Member

Divkix commented Jan 9, 2025

Can you update the change and also a description as to what and why you did?

Thanks for your response! "Update and change" - Could you clarify what updates or changes you'd like me to make

Here’s what I did:

  • Fixed typos, like moving the alt attribute from <a> to <img> for proper HTML.
  • Updated MongoDB usage: replaced deprecated NewClient with mongo.Connect and removed repetitive calls by using a variable for the database.
  • Improved error handling: switched to errors.Is for better error comparison.
  • Simplified Redis setup: replaced redis.NewClient with redis.ParseURL.
  • Updated the README with VPS deployment instructions."

Are you certain that you tried this code and this code works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AshokShau @Divkix