Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1051: Fix loss of precision error in vocabulary list #1052

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

lunars97
Copy link
Contributor

@lunars97 lunars97 commented Jan 20, 2025

Short description

After upgrading react native to v0.74, the react-native-paper was also updated which resulted in the loss precision error. The progress prop ofProgressBarcomponent caused this issue. The workaround is mentioned here

Proposed changes

  • Change the progress prop to animatedValue

Side effects

  • should be none :)

Resolved issues

Fixes: #1051


@lunars97 lunars97 force-pushed the 1051-fix-loss-of-precision-error-in-vocabulary-list branch from 0079e34 to 45dbe0e Compare January 20, 2025 15:57
Copy link
Member

@david-venhoff david-venhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

Tested on Android

@lunars97 lunars97 force-pushed the 1051-fix-loss-of-precision-error-in-vocabulary-list branch from 45dbe0e to 0bb40b6 Compare January 20, 2025 21:45
Copy link
Contributor

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on emulated iOS where I couldn't reproduce the original issue but this also didn't break anything 😅

@lunars97 lunars97 merged commit 06de7e2 into main Jan 22, 2025
2 checks passed
@lunars97 lunars97 deleted the 1051-fix-loss-of-precision-error-in-vocabulary-list branch January 22, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix loss of precision error in vocabulary list
3 participants