-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2940: Replace office icon #21
Conversation
fc1633c
to
8f77f7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. How can this be tested?
According to @f1sh1918 only by merging and deploying to production I think :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing quite like testing in production :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
We don't have a testing environment so far
I guess one way could be to use this repo as a submodule as we do it in entitlementcard
2940: Update other icons and iconset.json
Replace office icon and update iconset.json.
Move multipoi icon to the right group.
Fixes digitalfabrik/integreat-app#2940