Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2940: Replace office icon #21

Merged
merged 6 commits into from
Nov 6, 2024
Merged

2940: Replace office icon #21

merged 6 commits into from
Nov 6, 2024

Conversation

steffenkleinle
Copy link
Member

@steffenkleinle steffenkleinle commented Oct 25, 2024

Replace office icon and update iconset.json.
Move multipoi icon to the right group.
Fixes digitalfabrik/integreat-app#2940

@steffenkleinle steffenkleinle marked this pull request as draft October 25, 2024 06:06
Copy link
Member

@ztefanie ztefanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. How can this be tested?

@steffenkleinle
Copy link
Member Author

Looks good. How can this be tested?

According to @f1sh1918 only by merging and deploying to production I think :/

Copy link

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing quite like testing in production :D

Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
We don't have a testing environment so far
I guess one way could be to use this repo as a submodule as we do it in entitlementcard

2940: Update other icons and iconset.json
@steffenkleinle steffenkleinle merged commit d55a561 into gh-pages Nov 6, 2024
2 checks passed
@steffenkleinle steffenkleinle deleted the 2940-office-icon branch November 6, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old icon for Behörde/Amt still shown on map
4 participants