3007: Fix feeback rating for no search results as negative #3036
+90
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunars97
requested review from
steffenkleinle,
f1sh1918,
LeandraH and
bahaaTuffaha
as code owners
lunars97
force-pushed
the
3007-feedback-for-no-search-results-should-be-negative
branch
2 times, most recently
from
e4e5289 to
6d6e949
Compare
lunars97
force-pushed
the
3007-feedback-for-no-search-results-should-be-negative
branch
from
6d6e949 to
cfdbd3e
Compare
| @@ -11,7 +11,7 @@ type FeedbackModalContainerProps = { | |||
| } | |||
|
|
|||
| const FeedbackModalContainer = ({ route }: FeedbackModalContainerProps): ReactElement => ( | |||
| <FeedbackContainer {...route.params} /> | |||
| <FeedbackContainer {...route.params} noResults={false} /> | |||
There was a problem hiding this comment.
noResults is optional you can just add noResults = false at the FeedbackContainer props and remove this..
Suggested change
| <FeedbackContainer {...route.params} noResults={false} /> | |
| <FeedbackContainer {...route.params} /> |
| @@ -33,7 +41,10 @@ const FeedbackContainer = ({ query, language, routeType, cityCode, slug }: Feedb | |||
|
|
|||
| useEffect(() => { | |||
| setSearchTerm(query) | |||
| }, [query]) | |||
| if (noResults === true) { | |||
There was a problem hiding this comment.
Suggested change
| if (noResults === true) { | |
| if (noResults) { |
it's already a boolean
| @@ -28,11 +28,12 @@ describe('FeedbackContainer', () => { | |||
|
|
|||
| const city = 'augsburg' | |||
| const language = 'de' | |||
| const noResults = false | |||
There was a problem hiding this comment.
As long you add the default value false for noResults this is not needed
Suggested change
| const noResults = false |
|
|
||
| it('should send feedback request with rating and no other inputs on submit', async () => { | ||
| const { getByText, findByText } = render( | ||
| <NavigationContainer> | ||
| <FeedbackContainer routeType={CATEGORIES_ROUTE} language={language} cityCode={city} /> | ||
| <FeedbackContainer routeType={CATEGORIES_ROUTE} language={language} cityCode={city} noResults={noResults} /> |
There was a problem hiding this comment.
Suggested change
| <FeedbackContainer routeType={CATEGORIES_ROUTE} language={language} cityCode={city} noResults={noResults} /> | |
| <FeedbackContainer routeType={CATEGORIES_ROUTE} language={language} cityCode={city} /> |
| @@ -70,7 +71,7 @@ describe('FeedbackContainer', () => { | |||
| const contactMail = '[email protected]' | |||
| const { getByText, findByText, getAllByDisplayValue } = render( | |||
| <NavigationContainer> | |||
| <FeedbackContainer routeType={CATEGORIES_ROUTE} language={language} cityCode={city} /> | |||
| <FeedbackContainer routeType={CATEGORIES_ROUTE} language={language} cityCode={city} noResults={noResults} /> | |||
There was a problem hiding this comment.
Suggested change
| <FeedbackContainer routeType={CATEGORIES_ROUTE} language={language} cityCode={city} noResults={noResults} /> | |
| <FeedbackContainer routeType={CATEGORIES_ROUTE} language={language} cityCode={city} /> |
| @@ -106,7 +107,7 @@ describe('FeedbackContainer', () => { | |||
| it('should disable send feedback button if rating button is clicked twice', async () => { | |||
| const { getByText, findByText } = render( | |||
| <NavigationContainer> | |||
| <FeedbackContainer routeType={CATEGORIES_ROUTE} language={language} cityCode={city} /> | |||
| <FeedbackContainer routeType={CATEGORIES_ROUTE} language={language} cityCode={city} noResults={noResults} /> | |||
There was a problem hiding this comment.
Suggested change
| <FeedbackContainer routeType={CATEGORIES_ROUTE} language={language} cityCode={city} noResults={noResults} /> | |
| <FeedbackContainer routeType={CATEGORIES_ROUTE} language={language} cityCode={city} /> |
| @@ -22,9 +22,17 @@ export type FeedbackContainerProps = { | |||
| cityCode: string | |||
| query?: string | |||
| slug?: string | |||
| noResults: boolean | |||
There was a problem hiding this comment.
Suggested change
| noResults: boolean | |
| noResults?: boolean |
I think there is noResults only when I search and 0 results so it's false most of the time until we set it to true.
| routeType, | ||
| cityCode, | ||
| slug, | ||
| noResults, |
There was a problem hiding this comment.
Suggested change
| noResults, | |
| noResults = false, |
| language={language} | ||
| cityCode={city} | ||
| query={query} | ||
| noResults={noResults} |
There was a problem hiding this comment.
Suggested change
| noResults={noResults} |
| language={language} | ||
| cityCode={city} | ||
| query={query} | ||
| noResults={noResults} |
There was a problem hiding this comment.
Suggested change
| noResults={noResults} |
| language={language} | ||
| cityCode={city} | ||
| query='query' | ||
| noResults={noResults} |
There was a problem hiding this comment.
Suggested change
| noResults={noResults} |
| @@ -56,7 +56,7 @@ export const FeedbackContainer = ({ | |||
| query, | |||
| slug, | |||
| searchTerm, | |||
| isPositiveRating, | |||
| isPositiveRating: noResults === true ? false : isPositiveRating, | |||
There was a problem hiding this comment.
Suggested change
| isPositiveRating: noResults === true ? false : isPositiveRating, | |
| isPositiveRating: noResults ? false : isPositiveRating, |
|
Sorry about these comment should be in one review instead of 10 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
The feedback for search requests with no results is currently being sent as neutral. The implemented solution ensures that feedback will automatically be marked as negative when no results are found.
Side effects
Resolved issues
Fixes: #3007