Fix feeback rating for no search results as negative

digitalfabrik · Jan 10, 2025 · 9cef14f · 9cef14f
1 parent 5536887
commit 9cef14f
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 4 deletions.
diff --git a/native/src/components/FeedbackContainer.tsx b/native/src/components/FeedbackContainer.tsx
@@ -22,9 +22,17 @@ export type FeedbackContainerProps = {
   cityCode: string
   query?: string
   slug?: string
+  noResults: boolean
 }
 
-const FeedbackContainer = ({ query, language, routeType, cityCode, slug }: FeedbackContainerProps): ReactElement => {
+const FeedbackContainer = ({
+  query,
+  language,
+  routeType,
+  cityCode,
+  slug,
+  noResults,
+}: FeedbackContainerProps): ReactElement => {
   const [comment, setComment] = useState<string>('')
   const [contactMail, setContactMail] = useState<string>('')
   const [isPositiveRating, setIsPositiveRating] = useState<boolean | null>(null)
@@ -33,7 +41,10 @@ const FeedbackContainer = ({ query, language, routeType, cityCode, slug }: Feedb
 
   useEffect(() => {
     setSearchTerm(query)
-  }, [query])
+    if (noResults === true) {
+      setIsPositiveRating(false)
+    }
+  }, [query, noResults])
 
   const handleSubmit = () => {
     setSendingStatus('sending')

diff --git a/native/src/routes/SearchModal.tsx b/native/src/routes/SearchModal.tsx
@@ -89,7 +89,13 @@ const SearchModal = ({
               accessibilityLabel={t('searchResultsCount', { count: searchResults.length })}
               style={{ flex: 1 }}
               noItemsMessage={
-                <FeedbackContainer routeType={SEARCH_ROUTE} language={languageCode} cityCode={cityCode} query={query} />
+                <FeedbackContainer
+                  routeType={SEARCH_ROUTE}
+                  language={languageCode}
+                  cityCode={cityCode}
+                  noResults={searchResults.length === 0}
+                  query={query}
+                />
               }
             />
           </>

diff --git a/web/src/components/FeedbackContainer.tsx b/web/src/components/FeedbackContainer.tsx
@@ -40,7 +40,10 @@ export const FeedbackContainer = ({
 
   useEffect(() => {
     setSearchTerm(query)
-  }, [query])
+    if (noResults === true) {
+      isPositiveRating = false
+    }
+  }, [query, noResults])
 
   const handleSubmit = () => {
     setSendingStatus('sending')