-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
路由切换使用native-stack&相交api部分问题修复 #1815
base: master
Are you sure you want to change the base?
Conversation
initialRatio: 0, | ||
observeAll: false | ||
}, options || {}) | ||
this.thresholds = this.options.thresholds.sort((a, b) => a - b) || [0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|| [0]不需要了
@@ -26,7 +29,7 @@ class RNIntersectionObserver { | |||
this.margins = DefaultMargin | |||
this.callback = noop | |||
|
|||
this.throttleMeasure = this.getThrottleMeasure(options.throttleTime || 100) | |||
this.throttleMeasure = this.getThrottleMeasure(this.options.throttleTime || 100) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
默认值直接写在上面呗
@@ -65,7 +68,7 @@ class RNIntersectionObserver { | |||
|
|||
observe (selector, callback) { | |||
if (this.observerRefs) { | |||
console.error('"observe" call can be only called once in IntersectionObserver') | |||
console.warn('"observe" call can be only called once in IntersectionObserver') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
走utils中的logger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
把component传进去,可以有更多定位信息
left: this.margins.left, | ||
right: navigationLayout.width - this.margins.right, | ||
bottom: navigationLayout.y + navigationLayout.height - this.margins.bottom | ||
top: navigationLayout.y - this.margins.top, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为啥是这么改
@@ -505,14 +505,9 @@ export function getDefaultOptions ({ type, rawOptions = {}, currentInject }) { | |||
headerStyle: { | |||
backgroundColor: pageConfig.navigationBarBackgroundColor || '#000000' | |||
}, | |||
headerTintColor: pageConfig.navigationBarTextStyle || 'white' | |||
headerTintColor: pageConfig.navigationBarTextStyle || 'white', | |||
statusBarTranslucent: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
安卓statusbar那堆东西确定不要了?
No description provided.