Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

路由切换使用native-stack&相交api部分问题修复 #1815

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

thuman
Copy link
Collaborator

@thuman thuman commented Jan 15, 2025

No description provided.

initialRatio: 0,
observeAll: false
}, options || {})
this.thresholds = this.options.thresholds.sort((a, b) => a - b) || [0]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|| [0]不需要了

@@ -26,7 +29,7 @@ class RNIntersectionObserver {
this.margins = DefaultMargin
this.callback = noop

this.throttleMeasure = this.getThrottleMeasure(options.throttleTime || 100)
this.throttleMeasure = this.getThrottleMeasure(this.options.throttleTime || 100)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

默认值直接写在上面呗

@@ -65,7 +68,7 @@ class RNIntersectionObserver {

observe (selector, callback) {
if (this.observerRefs) {
console.error('"observe" call can be only called once in IntersectionObserver')
console.warn('"observe" call can be only called once in IntersectionObserver')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

走utils中的logger

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把component传进去,可以有更多定位信息

left: this.margins.left,
right: navigationLayout.width - this.margins.right,
bottom: navigationLayout.y + navigationLayout.height - this.margins.bottom
top: navigationLayout.y - this.margins.top,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥是这么改

@@ -505,14 +505,9 @@ export function getDefaultOptions ({ type, rawOptions = {}, currentInject }) {
headerStyle: {
backgroundColor: pageConfig.navigationBarBackgroundColor || '#000000'
},
headerTintColor: pageConfig.navigationBarTextStyle || 'white'
headerTintColor: pageConfig.navigationBarTextStyle || 'white',
statusBarTranslucent: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

安卓statusbar那堆东西确定不要了?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants