Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: accessibility updates from alpha #1511

Merged
merged 6 commits into from
Jun 3, 2024
Merged

feat: accessibility updates from alpha #1511

merged 6 commits into from
Jun 3, 2024

Conversation

kabaros
Copy link
Collaborator

@kabaros kabaros commented Jun 3, 2024

This is a cherry-pick for features already in alpha branch. Fixes:

Chisomchima and others added 5 commits June 3, 2024 11:31
@Chisomchima @kabaros
chore: update warning in button component (#1455)
1dc5439
@d-rita @kabaros
feat: add aria attributes to loaders (#1449)
aaa60fb 
* feat: add aria attributes to loaders

- Add aria-valuenow attribute to linear loader
- Add aria-label attribute to both linear and circular loaders
- Add unit tests for loaders

* refactor: change aria-label to use hyphen after code review

Co-authored-by: Diana Nanyanzi <[email protected]>

---------

Co-authored-by: Mozafar Haider <[email protected]>
Co-authored-by: Diana Nanyanzi <[email protected]>
@alaa-yahia @kabaros
feat(tooltip): accessibility improvements for tooltip (#1463)
9afcfdf 
* feat(tooltip): accessibility improvements for tooltip

* fix(tooltip): solve failing test
@Chisomchima @kabaros
feat: splitButton accessibility improvements (#1458)
8370915 
* feat: splitButton accessibility improvements

* feat: splitButton accessibility improvements

* feat: splitButton accessibility improvements

* refactor: apply code review comments (pairing session)

---------

Co-authored-by: Mozafar Haider <[email protected]>
@kabaros
refactor: fix lint issue
d455ffa
@kabaros kabaros requested a review from a team as a code owner June 3, 2024 10:35
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jun 3, 2024 •
edited
Loading

🚀 Deployed on https://pr-1511--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify June 3, 2024 10:38 Inactive
@cypress Cypress
Copy link

cypress bot commented Jun 3, 2024 •
edited
Loading

Passing run #3415 ↗︎

0 584 0 0 Flakiness 0

Details:

fix(Tooltip): add missing tabIndex
Project: ui Commit: 389e61aa40
Status: Passed Duration: 09:36 💡
Started: Jun 3, 2024 1:40 PM Ended: Jun 3, 2024 1:49 PM

Review all test suite changes for PR #1511 ↗︎

@kabaros kabaros changed the title Accessibility updates from alpha feat: accessibility updates from alpha Jun 3, 2024
d-rita
d-rita reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@d-rita d-rita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of thoughts (might be out of scope of the tickets):

  1. Tested the split button and i think we should be able to Tab it - just like the button component and activate it when i press Enter. Since there are 2 buttons, I can tab to any of the 2 to activate what i want. The Esc functionality after viewing the dropdown content works as expected.

  2. Tested the Tooltip. I can move focus to the one with a button trigger by tabbing to it, but the tooltip does not show as expected when the trigger receives focus. The 'Esc' functionality does work for the button trigger example.

@dhis2-bot dhis2-bot temporarily deployed to netlify June 3, 2024 13:37 Inactive
@alaa-yahia
Copy link
Member

alaa-yahia commented Jun 3, 2024 •
edited
Loading

Couple of thoughts (might be out of scope of the tickets):

  1. Tested the split button and i think we should be able to Tab it - just like the button component and activate it when i press Enter. Since there are 2 buttons, I can tab to any of the 2 to activate what i want. The Esc functionality after viewing the dropdown content works as expected.
  2. Tested the Tooltip. I can move focus to the one with a button trigger by tabbing to it, but the tooltip does not show as expected when the trigger receives focus. The 'Esc' functionality does work for the button trigger example.

@d-rita The issue with the Tooltip arises from the missing tabIndex. Since it is a <span> element, it will not receive focus by default. Please verify if it now works as expected after adding the tabIndex.
Thank you

@d-rita
Copy link
Contributor

d-rita commented Jun 3, 2024

@alaa-yahia Tooltip works as expected 🎉

@kabaros kabaros enabled auto-merge June 3, 2024 15:47
@kabaros kabaros disabled auto-merge June 3, 2024 15:53
@kabaros kabaros merged commit d8aea01 into master Jun 3, 2024
13 checks passed
@kabaros kabaros deleted the accessibility-updates-from-alpha branch June 3, 2024 15:53
@Chisomchima
Copy link
Member

Chisomchima commented Jun 3, 2024 •
edited
Loading

@d-rita your concerns have been added to a new ticketand implementations can be found on this PR

@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 9.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaa-yahia alaa-yahia alaa-yahia left review comments

@d-rita d-rita d-rita approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kabaros @dhis2-bot @alaa-yahia @d-rita @Chisomchima