Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up from pr review #1456

Merged
merged 6 commits into from
Feb 16, 2024
Merged

fix: clean up from pr review #1456

merged 6 commits into from
Feb 16, 2024

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Feb 16, 2024

This PR makes fixes suggsted by @KaiVandivier in PR review for merge from alpha to main: #1452

@tomzemp tomzemp requested a review from a team as a code owner February 16, 2024 14:43
@tomzemp tomzemp requested a review from KaiVandivier February 16, 2024 14:43
Copy link

cypress bot commented Feb 16, 2024

Passing run #3236 ↗︎

0 584 0 0 Flakiness 0

Details:

fix: refine chip margin logic
Project: ui Commit: 9e6793dd25
Status: Passed Duration: 06:43 💡
Started: Feb 16, 2024 2:51 PM Ended: Feb 16, 2024 2:58 PM

Review all test suite changes for PR #1456 ↗︎

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-1456--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify February 16, 2024 14:47 Inactive
@tomzemp tomzemp changed the title fix: PR clean up fix: clean up from pr review Feb 16, 2024
Copy link
Contributor

@KaiVandivier KaiVandivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙌

@tomzemp tomzemp merged commit ced3e26 into alpha Feb 16, 2024
14 of 15 checks passed
@tomzemp tomzemp deleted the alpha-rtl-fixes branch February 16, 2024 19:20
@cypress cypress bot mentioned this pull request Feb 16, 2024
6 tasks
dhis2-bot added a commit that referenced this pull request Feb 16, 2024
# [9.4.0-alpha.2](v9.4.0-alpha.1...v9.4.0-alpha.2) (2024-02-16)

### Bug Fixes

* clean up from pr review ([#1456](#1456)) ([ced3e26](ced3e26))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 9.4.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants