Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(segmented-control): adjust design and accessibility #1443

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

cooper-joe
Copy link
Member

@cooper-joe cooper-joe commented Jan 8, 2024

Implements LIBS-568 and UX-160


Description

This PR improves accessibility and adjusts the design of the SegmentedControl component.


Screenshots

Before:
image

After:
image

@cooper-joe cooper-joe requested a review from a team as a code owner January 8, 2024 11:21
@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-1443--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify January 8, 2024 11:25 Inactive
Copy link

cypress bot commented Jan 8, 2024

Passing run #3189 ↗︎

0 584 0 0 Flakiness 0

Details:

docs(segmented-control): add long label and aria label storybook examples
Project: ui Commit: e20c405c57
Status: Passed Duration: 06:49 💡
Started: Jan 8, 2024 11:26 AM Ended: Jan 8, 2024 11:33 AM

Review all test suite changes for PR #1443 ↗︎

Copy link
Contributor

@KaiVandivier KaiVandivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cooper-joe cooper-joe merged commit 53b9f83 into master Jan 11, 2024
15 checks passed
@cooper-joe cooper-joe deleted the segmented-control-design branch January 11, 2024 07:44
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 9.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants