fix(constants): remove buttonVariantProptype from constants #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1436--dhis2-ui.netlify.app |
Passing run #3155 ↗︎
Details:
Review all test suite changes for PR #1436 ↗︎ |
|||||||||||||||
BREAKING CHANGE: `buttonVariantPropType` has been removed from constants. This is mostly intended for internal purposes, but was part of the public API.
Birkbjo
force-pushed
the
prepare-alpha-9
branch
from
6906728 to
c23a6b9
Compare
kabaros
approved these changes
Dec 6, 2023
dhis2-bot
added a commit
that referenced
this pull request
Dec 6, 2023
# [9.0.0-alpha.1](v8.16.0-alpha.2...v9.0.0-alpha.1) (2023-12-06) ### Bug Fixes * **constants:** remove buttonVariantProptype from constants ([#1436](#1436)) ([d4dc535](d4dc535)) ### BREAKING CHANGES * **constants:** `buttonVariantPropType` has been removed from constants. This is mostly intended for internal use, but was part of the public API.
dhis2-bot
added a commit
that referenced
this pull request
Dec 8, 2023
# [9.0.0](v8.16.0...v9.0.0) (2023-12-08) ### Bug Fixes * **constants:** remove buttonVariantProptype from constants ([#1436](#1436)) ([d4dc535](d4dc535)) * **package:** include types in exports field ([e16036b](e16036b)) * **types:** add type declarations for components ([#1399](#1399)) ([d3e74c5](d3e74c5)) * **types:** minor type fixes ([#1434](#1434)) [skip release] ([5e1068d](5e1068d)) * minor type fixes ([#1416](#1416)) ([71f4537](71f4537)) ### Features * **types:** add types for forms collection ([#1415](#1415)) ([2e9d91a](2e9d91a)) ### BREAKING CHANGES * **constants:** `buttonVariantPropType` has been removed from constants. This is mostly intended for internal use, but was part of the public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepares alpha 9 release. Fixes some bad merge resolutions, and brings back
buttonVariantArgTypethat is used for storybook.BREAKING CHANGE:
buttonVariantPropTypehas been removed from constants. This is mostly intended for internal purposes, but was part of the public API.