feat(button): add destructive, secondary button type #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1424--dhis2-ui.netlify.app |
Passing run #3133 ↗︎
Details:
Review all test suite changes for PR #1424 ↗︎ |
|||||||||||||||
kabaros
reviewed
Nov 17, 2023
Thanks for the heads up. This should just be a simple boolean in the types. I will update the alpha branch once this is merged, and create a PR for it. I abandoned the XOR typings, as I don't think it's worth the complexity (and readability of the resulting types). Which is also in line with option 3 of @Mohammer5 suggestion above. |
Mohammer5
approved these changes
Nov 23, 2023
feat(shared-prop-types): extract secondary button prop from exclusive props style(button): adjust secondary destructive font weight fix(button): remove exclusivity of type props docs(button): add destructive secondary example
cooper-joe
force-pushed
the
button-secondary-destructive
branch
from
184c64a to
b72a04a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements LIBS-544 / UX-157
Description
This PR implements, or allows, buttons that are both
destructiveandsecondary.secondaryprop is now used as a modifier rather than a standalone type, as it can be applied to bothbasicanddestructivetypes. (Usingsecondaryalone is considered a modifier applied to the defaultbasictype.)In order to allow this, the
secondaryprop is no longer part of the shared prop types provided by UI constants.Question: is this a breaking change? I believe all button usages are unaffected by this change, but I'm not sure if changing
PropTypedefinitions always counts as a breaking change.Checklist
All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.
Screenshots