fix(validation): use dynamic schema validator for common fields #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
flaminic
reviewed
Jan 16, 2025
flaminic
approved these changes
Jan 16, 2025
dhis2-bot
added a commit
that referenced
this pull request
Jan 16, 2025
## [0.23.1](v0.23.0...v0.23.1) (2025-01-16) ### Bug Fixes * **validation:** use dynamic schema validator for common fields ([#494](#494)) ([0ff52ee](0ff52ee))
|
🎉 This PR is included in version 0.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the comment in regards to
shortNamevalidation: https://dhis2.atlassian.net/browse/DHIS2-18538shortNameused the wrong field to check against: probably due to copy/paste errors. I've updated the common fieldsname, andshortNameto use theuseValidatorwhich uses the schema to decide which validation to apply to the fields. This should streamline the validations, and also fixes some discrepancies, because previouslyuniquewas always checked forname- but this is not necessarily correct. Eg. the schema does not defineunique: truefororganisationUnitanddataSets.