fix: reset paging when clearing filters

dhis2 · Jan 29, 2024 · fdb0b10 · fdb0b10
1 parent 5c06c37
commit fdb0b10
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/src/lib/sectionList/filters/useSectionListFilters.ts b/src/lib/sectionList/filters/useSectionListFilters.ts
@@ -1,9 +1,6 @@
 import { useCallback, useMemo } from 'react'
 import { useQueryParams } from 'use-query-params'
-import {
-    usePaginationQueryParams,
-    useUpdatePaginationParams,
-} from '../usePaginationParams'
+import { usePaginationQueryParams } from '../usePaginationParams'
 import {
     ParsedFilterParams,
     filterQueryParamType,
@@ -34,9 +31,10 @@ export const useSectionListFilters = () => {
                 const resetParams = Object.fromEntries(
                     validFilterKeys.map((key) => [key, undefined])
                 )
-                return setFilterParams(resetParams)
+                setFilterParams(resetParams)
+            } else {
+                setFilterParams(filter, updateType)
             }
-            setFilterParams(filter, updateType)
             // set page to 1 when filter changes
             // do this here instead of useEffect to prevent unnecessary refetches
             setPagingParams((pagingParams) => ({ ...pagingParams, page: 1 }))