feat: Add data element name as a fallback when sorting [DHIS2-18871] #19729
+28
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
enricocolasante
approved these changes
Jan 20, 2025
| .getItems(); | ||
|
|
||
| assertNumberOfChanges(7, changeLogs); | ||
| assertAll( |
There was a problem hiding this comment.
Maybe we could have an assertion just to check the order like mapping the changelogs to the order field (if possible) or to the UID and make a comment to show what is the value of the name.
Something like:
expected = List.of("with-option-set", "test-dataleement6", "test-dataelement1", "test-dataelement1", "test-dataelement1", "scheduledAt", "occurredAt")
This way would be easy to understand why the assertion makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding data element name as a fallback in case form name is not set when sorting data elements change logs