fix: Fix failing pipeline test [DHIS2-18870] #19728
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
enricocolasante
approved these changes
Jan 20, 2025
david-mackessy
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testGetAuditsByParamsis failing on the pipelineThis tests works locally.
It fails on the pipeline because when it's run, the database is in an inconsistent state.
The test expects to find two entries when searching for
CREATEandDELETEaudit entries, but there are two otherDELETEentries created by the admin user, unrelated to the test, so it fails.I've tried to figure out what's the test responsible of those two entries, but I haven't managed to find it so far.
I thought it was the
DeduplicationServiceMergeIntegrationTest, as it createsDELETEentries and it was not marked as Transactional, but turns out it's not.I don't want to spend more time on this, so for now I'm refactoring the test to get only the entries of the users related to this test class.