fix: IN filter now works with org units data elements [DHIS2-18845] #19727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giuseppe Nespolino <[email protected]>
Signed-off-by: Giuseppe Nespolino <[email protected]>
Signed-off-by: Giuseppe Nespolino <[email protected]>
Signed-off-by: Giuseppe Nespolino <[email protected]>
… into DHIS2-18845_IN_with_ORG_UNIT_DE
gnespolino
requested review from
luciano-fiandesio,
larshelge and
maikelarabori
Signed-off-by: Giuseppe Nespolino <[email protected]>
|
maikelarabori
approved these changes
Jan 20, 2025
| public List<String> getOrgUnitDimensionUid( | ||
| List<String> items, List<OrganisationUnit> userOrgUnits) { | ||
| return getOrgUnitDimensionItems( | ||
| items, userOrgUnits, IdScheme.UID, new ArrayList<>(), new ArrayList<>()) |
There was a problem hiding this comment.
Could we use List.of(), instead of new ArrayList<>()?
There was a problem hiding this comment.
for some reason, those lists need to be mutable. So cannot use List.of()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will fix a small bug with IN query operator, making it properly quotes values when needed (it was only quoting
TEXTvalue types before).Moreover, it will properly support Data Elements of type ORG_UNIT, by replacing the filter values with org unit UIDs when needed