refactor: Option dimension in Visualization [DHIS2-18370]

[maikelarabori]

Making the option set / item adherent to the existing model objects.
Before this change, the JSON request/response would look like:

            "items": [
                {
                    "id": "IpHINAT79UW.CklPZdOd6H1",
                    "dimensionItemType": "PROGRAM_DATA_ELEMENT",
                    "optionSetItem": {
                        "aggregation": "DISAGGREGATED",
                        "options": [
                            {
                                "id": "AZK4rjJCss5"
                            },
                            {
                                "id": "UrUdMteQzlT"
                            }
                        ]
                    }
                }
            ]

            "items": [
                {
                    "id": "IpHINAT79UW.UuL3eX8KJHY.koZkOwyJbSQ",
                    "dimensionItemType": "PROGRAM_DATA_ELEMENT_OPTION"
                },
                                {
                    "id": "IpHINAT79UW.UuL3eX8KJHY.uODmvdTEeMr.AGGREGATED",
                    "dimensionItemType": "PROGRAM_DATA_ELEMENT_OPTION"
                },
                {
                    "id": "IpHINAT79UW.CklPZdOd6H1.AZK4rjJCss5.DISAGGREGATED",
                    "dimensionItemType": "PROGRAM_ATTRIBUTE_OPTION"
                },
                                {
                    "id": "IpHINAT79UW.CklPZdOd6H1.UrUdMteQzlT.DISAGGREGATED",
                    "dimensionItemType": "PROGRAM_ATTRIBUTE_OPTION"
                }
            ]

Even though, it looks less concise (from the representation point of view) it follows the same standard of existing dimensions. After a conversation with @larshelge , this the preferred way.

[luciano-fiandesio]

Not sure what is the convention, but wouldn't be better to return Option< ProgramTrackedEntityAttributeOptionDimensionItem>?

[maikelarabori]

We could, but I applied the same convention from all other existing methods. It can be refactored all together later if this is the case.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.7% Duplication on New Code

See analysis details on SonarQube Cloud