-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: align fetching a single vs multiple enrollments [DHIS2-18791] #19705
base: master
Are you sure you want to change the base?
Conversation
...service-tracker/src/main/java/org/hisp/dhis/tracker/export/enrollment/EnrollmentService.java
Dismissed
Show dismissed
Hide dismissed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19705 +/- ##
=============================================
+ Coverage 49.00% 67.39% +18.39%
- Complexity 257 640 +383
=============================================
Files 3481 3481
Lines 126225 126253 +28
Branches 14157 14153 -4
=============================================
+ Hits 61851 85086 +23235
+ Misses 59002 34722 -24280
- Partials 5372 6445 +1073
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1278 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Quality Gate passedIssues Measures |
Use the same path to retrieve one enrollment and multiple enrollments.
In order to achieve that when getting one enrollment we are using the get multiple enrollments method and return a
NotFoundException
if something goes wrong (this is sometimes replacing the previousForbiddenException
because the multiple enrollment method is filtering out inaccessible enrollments. This is working the same way in event exporter).Other changes
UserDetails.fromUser
to properly initialize search and capture scope for users in tests.NotFoundException
instead ofForbiddenException
)