fix: System settings endpoint returns expected Cache-Control header v… #15888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alue DHIS2-15196
Summary
Security issue raised so that we set the following values for the
Cache-Control
header on the/api/systemSettings
endpoint:Code added to
ContextUtils
for easy reuse.Note
This was the easiest and simplest way to have the combination of these 3 header values contained in 1 header key.
The Spring
CacheControl
class is not nice to work with at all when trying to get these 3 specific values together (mix of static and non-static methods)Testing
Automated
Manual
GET /api/systemSettings
Cache-Control
no-cache, no-store, must-revalidate