fix: wait until file resource content is available #15686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## tracker_importer_scheduler #15686 +/- ##
=============================================================
Coverage 66.20% 66.21%
- Complexity 31272 31282 +10
=============================================================
Files 3483 3483
Lines 129897 129911 +14
Branches 15179 15182 +3
=============================================================
+ Hits 86002 86024 +22
+ Misses 36810 36807 -3
+ Partials 7085 7080 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
jbee
commented
Nov 14, 2023
| @@ -33,6 +33,5 @@ | |||
| public enum FileResourceStorageStatus { | |||
| NONE, // No content stored | |||
| PENDING, // In transit to store, not available | |||
| FAILED, // Storing the resource failed | |||
There was a problem hiding this comment.
FYI: This was never used anywhere so it seemed just confusing to have
jbee
added a commit
that referenced
this pull request
Nov 14, 2023
* "chore: Make async tracker importer use scheduler" This reverts commit bc2befc. * fix: wait until file resource content is available (#15686) * fix: wait until file resource content is available * fix: detect null content for file resources * fix: wait for file content to become available --------- Co-authored-by: Jan Bernitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileResourcecontent is stored asynchronously which makes it difficult to work with immediately after calling "save".Therefore a sleep-waiting was added.