Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for Hikari pool metrics [DHIS2-15419] #15623

Merged
merged 5 commits into from
Nov 8, 2023

fix: add support for Hikari pool metrics

4e3eed1
Select commit
Loading
Failed to load commit list.
Merged

fix: add support for Hikari pool metrics [DHIS2-15419] #15623

fix: add support for Hikari pool metrics
4e3eed1
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Nov 8, 2023 in 0s

66.23% (+0.00%) compared to 178839d

View this Pull Request on Codecov

66.23% (+0.00%) compared to 178839d

Details

Codecov Report

Merging #15623 (4e3eed1) into master (178839d) will increase coverage by 0.00%.
Report is 10 commits behind head on master.
The diff coverage is 2.08%.

@@            Coverage Diff            @@
##             master   #15623   +/-   ##
=========================================
  Coverage     66.23%   66.23%           
- Complexity    31250    31264   +14     
=========================================
  Files          3485     3487    +2     
  Lines        129791   129811   +20     
  Branches      15145    15146    +1     
=========================================
+ Hits          85965    85980   +15     
- Misses        36741    36748    +7     
+ Partials       7085     7083    -2     
Files Coverage Δ
.../monitoring/metrics/jdbc/C3p0MetadataProvider.java 0.00% <ø> (ø)
...isp/dhis/monitoring/metrics/jdbc/PoolMetadata.java 0.00% <ø> (ø)
.../monitoring/metrics/jdbc/AbstractPoolMetadata.java 0.00% <0.00%> (ø)
...ng/metrics/jdbc/CompositePoolMetadataProvider.java 0.00% <0.00%> (ø)
...monitoring/metrics/jdbc/PoolMetadataProviders.java 0.00% <0.00%> (ø)
...onitoring/metrics/DataSourcePoolMetricsConfig.java 16.66% <11.11%> (-7.15%) ⬇️
...onitoring/metrics/jdbc/HikariMetadataProvider.java 0.00% <0.00%> (ø)
...hisp/dhis/monitoring/metrics/jdbc/PoolMetrics.java 0.00% <0.00%> (ø)
...oring/metrics/jdbc/HikariPoolMetadataAccessor.java 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178839d...4e3eed1. Read the comment docs.