Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove program prefix from TEAs in CPL [DHIS2-16067] #15579

Merged
merged 6 commits into from
Nov 5, 2023

Conversation

gnespolino
Copy link
Contributor

No description provided.

@gnespolino gnespolino added the run-api-analytics-tests Enables analytics e2e tests label Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #15579 (c7a0749) into master (0b88bbb) will increase coverage by 16.73%.
The diff coverage is 70.00%.

@@              Coverage Diff              @@
##             master   #15579       +/-   ##
=============================================
+ Coverage     49.49%   66.23%   +16.73%     
- Complexity    23294    31249     +7955     
=============================================
  Files          3485     3485               
  Lines        129788   129791        +3     
  Branches      15141    15145        +4     
=============================================
+ Hits          64239    85966    +21727     
+ Misses        59477    36739    -22738     
- Partials       6072     7086     +1014     
Flag Coverage Δ
integration 49.78% <4.28%> (?)
integration-h2 32.42% <0.00%> (+<0.01%) ⬆️
unit 30.34% <68.57%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...a/org/hisp/dhis/analytics/tei/query/TeiFields.java 41.58% <100.00%> (-1.40%) ⬇️
...ei/query/context/querybuilder/TeiQueryBuilder.java 69.56% <ø> (ø)
...a/org/hisp/dhis/analytics/util/AnalyticsUtils.java 73.96% <100.00%> (+4.69%) ⬆️
.../webapi/controller/tei/TeiAnalyticsController.java 0.00% <ø> (ø)
...i/dimension/EnrollmentAnalyticsPrefixStrategy.java 50.00% <100.00%> (+50.00%) ⬆️
...nsion/mappers/BaseDimensionalItemObjectMapper.java 88.23% <100.00%> (-0.66%) ⬇️
...s/webapi/dimension/TeiAnalyticsPrefixStrategy.java 0.00% <0.00%> (ø)
.../analytics/event/data/DefaultQueryItemLocator.java 85.56% <25.00%> (-2.74%) ⬇️
.../dhis/webapi/dimension/DimensionMapperService.java 73.33% <66.66%> (+73.33%) ⬆️
...cs/common/processing/CommonQueryRequestMapper.java 85.71% <86.66%> (-0.23%) ⬇️
... and 2 more

... and 1217 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b88bbb...c7a0749. Read the comment docs.

Copy link
Contributor

@maikelarabori maikelarabori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Just a comment: would be nice to have a few e2e for CPL that send requests without the program.

Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@gnespolino gnespolino merged commit 1253d7a into master Nov 5, 2023
18 checks passed
@gnespolino gnespolino deleted the DHIS2-16067_remove-programUid-prefix-for-TEAs branch November 5, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-api-analytics-tests Enables analytics e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants