fix: only exclude actual 'run once' jobs from scheduler main list [DHIS2-16074] #15494
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
| return schedulingType == SchedulingType.ONCE_ASAP | ||
| && cronExpression == null | ||
| && delay == null | ||
| && queueName == null; |
There was a problem hiding this comment.
FYI: the reason to check all the fields is so we do not exclude scheduled jobs which got executed manually so their schedulingType shortly switches to ONCE_ASAP as well but they still have a cronExpression.
Codecov Report
@@ Coverage Diff @@
## master #15494 +/- ##
=============================================
+ Coverage 49.48% 66.15% +16.67%
- Complexity 23291 31188 +7897
=============================================
Files 3489 3487 -2
Lines 129699 129761 +62
Branches 15136 15136
=============================================
+ Hits 64176 85842 +21666
+ Misses 59448 36834 -22614
- Partials 6075 7085 +1010
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1236 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Summary
The filter applied to the scheduler main list was too unspecific and would also filter out disabled jobs that were removed from a queue and therefore would not have a CRON expression or delay time.
Manual Testing
/api/scheduleras disabled