-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: split fetching all TEs from fetching paginated TEs [TECH-1645] #15475
Conversation
0beccfa
to
434aee1
Compare
...rc/main/java/org/hisp/dhis/webapi/controller/tracker/export/trackedentity/RequestParams.java
Dismissed
Show dismissed
Hide dismissed
...rc/main/java/org/hisp/dhis/webapi/controller/tracker/export/trackedentity/RequestParams.java
Dismissed
Show dismissed
Hide dismissed
...rc/main/java/org/hisp/dhis/webapi/controller/tracker/export/trackedentity/RequestParams.java
Dismissed
Show dismissed
Hide dismissed
...rc/main/java/org/hisp/dhis/webapi/controller/tracker/export/trackedentity/RequestParams.java
Dismissed
Show dismissed
Hide dismissed
...t-integration/src/test/java/org/hisp/dhis/tracker/export/OrderAndPaginationExporterTest.java
Outdated
Show resolved
Hide resolved
Update dhis-2/dhis-test-integration/src/test/java/org/hisp/dhis/tracker/export/OrderAndPaginationExporterTest.java chore: split fetching all TEs from fetching paginated TEs [TECH-1661] chore: split fetching all TEs from fetching paginated TEs [TECH-1661]
8057eee
to
180976d
Compare
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #15475 +/- ##
============================================
- Coverage 66.16% 66.15% -0.01%
Complexity 31175 31175
============================================
Files 3489 3489
Lines 129635 129654 +19
Branches 15123 15123
============================================
+ Hits 85773 85774 +1
- Misses 36775 36792 +17
- Partials 7087 7088 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Continuing the work already done for
enrollments
(#15434) totracked entities
PageParam
class that contains the defaults forpage
,pageSize
and uses primitive typesint
,boolean
.skipPaging
Next PR(s)
Push the pagination logic we currently have in the service into the repository. This will remove a source of error and make the code cleaner. As right now the repository fetches
pageSize+1
iftotalPages=false
to see if the page is the last page. The service then removes that extra page. All of that will live in the repository.