refactor: Remove embedded filter property (#19176)

dhis2 · Nov 15, 2024 · 6cb7971 · 6cb7971
1 parent 01994b3
commit 6cb7971
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/dhis-2/dhis-api/src/main/java/org/hisp/dhis/dashboard/embedded/EmbeddedOptions.java b/dhis-2/dhis-api/src/main/java/org/hisp/dhis/dashboard/embedded/EmbeddedOptions.java
@@ -52,7 +52,4 @@ public class EmbeddedOptions implements Serializable {
 
   /** Filter options. Applies to Superset. */
   @JsonProperty private FilterOptions filters;
-
-  /** Show the filters panel. Applies to Superset. */
-  @JsonProperty private boolean showFilters;
 }
diff --git a/dhis-2/dhis-test-integration/src/test/java/org/hisp/dhis/dashboard/DashboardServiceTest.java b/dhis-2/dhis-test-integration/src/test/java/org/hisp/dhis/dashboard/DashboardServiceTest.java
@@ -170,7 +170,7 @@ void setUp() {
         new EmbeddedDashboard(
             EmbeddedProvider.SUPERSET,
             UUID_A,
-            new EmbeddedOptions(true, true, new FilterOptions(true, true), true)));
+            new EmbeddedOptions(true, true, new FilterOptions(true, true))));
   }
 
   @Test
@@ -193,7 +193,6 @@ void testSaveGet() {
     assertNotNull(rdC.getEmbedded().getOptions());
     assertTrue(rdC.getEmbedded().getOptions().isHideChartControls());
     assertTrue(rdC.getEmbedded().getOptions().isHideChartControls());
-    assertTrue(rdC.getEmbedded().getOptions().isShowFilters());
   }
 
   @Test