feat: Add data element name as a fallback when sorting [DHIS2-18871]

dhis2 · Jan 20, 2025 · 320dde8 · 320dde8
1 parent 5510546
commit 320dde8
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/...racker/src/main/java/org/hisp/dhis/tracker/export/event/HibernateEventChangeLogStore.java b/...racker/src/main/java/org/hisp/dhis/tracker/export/event/HibernateEventChangeLogStore.java
@@ -58,7 +58,9 @@ public class HibernateEventChangeLogStore {
   private static final String COLUMN_CHANGELOG_DATA_ELEMENT = "d.uid";
   private static final String COLUMN_CHANGELOG_FIELD = "ecl.eventField";
   private static final String ORDER_CHANGE_EXPRESSION =
-      "CONCAT(COALESCE(d.formName, ''), COALESCE(" + COLUMN_CHANGELOG_FIELD + ", ''))";
+      "CONCAT(COALESCE(d.formName, ''), COALESCE(d.name, ''), COALESCE("
+          + COLUMN_CHANGELOG_FIELD
+          + ", ''))";
   private static final String DEFAULT_ORDER =
       COLUMN_CHANGELOG_CREATED + " " + SortDirection.DESC.getValue();
 

diff --git a/...on/src/test/java/org/hisp/dhis/tracker/export/event/OrderAndFilterEventChangeLogTest.java b/...on/src/test/java/org/hisp/dhis/tracker/export/event/OrderAndFilterEventChangeLogTest.java
@@ -268,6 +268,31 @@ void shouldSortChangeLogsWhenOrderingByChangeDescAndChangesOnlyToEventFields()
         () -> assertFieldCreate("geometry", "(-11.419700, 8.103900)", changeLogs.get(4)));
   }
 
+  @Test
+  void shouldSortChangeLogsByNameWhenOrderingByChangeAndDataElementDoesNotHaveFormName()
+      throws ForbiddenException, NotFoundException {
+    EventChangeLogOperationParams params =
+        EventChangeLogOperationParams.builder().orderBy("change", SortDirection.DESC).build();
+    Event event = getEvent("pTzf9KYMk72");
+
+    updateDataValues(event, "DATAEL00001", "value00002", "value00003");
+
+    List<EventChangeLog> changeLogs =
+        eventChangeLogService
+            .getEventChangeLog(UID.of("pTzf9KYMk72"), params, defaultPageParams)
+            .getItems();
+
+    assertNumberOfChanges(7, changeLogs);
+    assertAll(
+        () -> assertDataElementCreate("DATAEL00005", "option1", changeLogs.get(0)),
+        () -> assertDataElementCreate("DATAEL00006", "88", changeLogs.get(1)),
+        () -> assertDataElementUpdate("DATAEL00001", "value00002", "value00003", changeLogs.get(2)),
+        () -> assertDataElementUpdate("DATAEL00001", "value00001", "value00002", changeLogs.get(3)),
+        () -> assertDataElementCreate("DATAEL00001", "value00001", changeLogs.get(4)),
+        () -> assertFieldCreate("scheduledAt", "2019-01-28 12:32:38.100", changeLogs.get(5)),
+        () -> assertFieldCreate("occurredAt", "2019-01-25 12:10:38.100", changeLogs.get(6)));
+  }
+
   @Test
   void shouldFilterChangeLogsWhenFilteringByUser() throws ForbiddenException, NotFoundException {
     EventChangeLogOperationParams params =