chore: sonarqube fixes

[jenniferarnesen]

SonarQube analysis reported issues on the latest code changes. Even though this is not a required check, we should comply when the suggestions are sensible. Here's a link to the findings: https://sonarcloud.io/summary/new_code?id=dhis2_dashboard-app&branch=master

Summary of changes and the quality that was flagged by Sonarqube:

• ActionsBar: break up nested ternary (maintainability)
• InformationBlock.module.css and SlideshowControlbar.module.css: missing generic font, but since this is declared higher up in the html structure for all elements (*), font-family declarations can be removed all-together in the app (reliability)
• NavigationMenu.js: remove role="listitem" on li element since it is is implicit (reliability, maintainability)
• ContentMenuItem.js: non-interactive element needs key handler. Fix was to make it semantically correct and switch to an interactive element button (reliability, maintainability)
• StartScreen.module.css: remove shorthand style that followed a more specific style (reliability)
• spec files - use object spread instead of Object.assign (conventional, maintainability)

What needs to be tested:

• start screen: that the bullets on the list of recent dashboards looks the same
• edit view item selector: that the launch link of each visualization looks the same and still works
• that the slideshow button has the correct tooltip content
• InformationBlock and Slideshow controller have the correct font
• Dashboard dropdown "No dashboards found" looks correct

[dhis2-bot]

🚀 Deployed on https://pr-3182.dashboard.netlify.dhis2.org

[HendrikThePendric]

I left two suggestions in the code, but nothing critical.

I also compared the Netlify-deployed app with the app on https://test.e2e.dhis2.org/analytics-41dev/ and did spot a small regression.

edit view item selector: that the launch link of each visualization looks the same and still works

The functionality is fine, but the cursor style is now a bit odd (on MacOS at least). The launch-link has a default cursor while the menu item has a cursor: pointer;. On the test instance they both have cursor: pointer;. FYI: it'd be good to also show a background color change on hover as a visual aid for the user, but I guess that's out-of-scope for now...

One other note: I did not run the branch locally and could not work out how to test the following point on Netlify:

Dashboard dropdown "No dashboards found" looks correct

But since I could not actually spot any potentially relevant file changes in the PR diff, I just assumed this point would be fine.
I have tested this point too and it looked good.

[jenniferarnesen]

I left two suggestions in the code, but nothing critical.

I also compared the Netlify-deployed app with the app on https://test.e2e.dhis2.org/analytics-41dev/ and did spot a small regression.

edit view item selector: that the launch link of each visualization looks the same and still works

The functionality is fine, but the cursor style is now a bit odd (on MacOS at least). The launch-link has a default cursor while the menu item has a cursor: pointer;. On the test instance they both have cursor: pointer;. FYI: it'd be good to also show a background color change on hover as a visual aid for the user, but I guess that's out-of-scope for now...

One other note: I did not run the branch locally and could not work out how to test the following point on Netlify:

Dashboard dropdown "No dashboards found" looks correct

But since I could not actually spot any potentially relevant file changes in the PR diff, I just assumed this point would be fine. I have tested this point too and it looked good.

Addressed. The button now uses cursor pointer on hover, and the color of the icon is darker on hover. Nice improvement if you ask me...

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud