Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: slide show backup (to be deleted) #3172

Closed
wants to merge 91 commits into from
Closed

feat: slide show backup (to be deleted) #3172

wants to merge 91 commits into from

Conversation

jenniferarnesen
Copy link
Collaborator

Implements DHIS2-XXXX

Requires https://github.com/dhis2/analytics/pull/XXX

Key features

  1. feature

Description

text

TODO

  • task

Known issues

  • issue

Screenshots

supporting text

jenniferarnesen and others added 30 commits September 3, 2024 11:43
@jenniferarnesen
chore: update ItemGrid to current standard and fix missing dep in use…
fa9f0d5 
…Effect
@jenniferarnesen
feat: fullscreen for visualization items
3d3990e
@jenniferarnesen
feat: add the navigation buttons and keep track of current index in I…
6f604b0 
…temGrid
@jenniferarnesen
fix: remove stray char
f25c305
@jenniferarnesen
chore: full of debug comments
6033db1
@jenniferarnesen
feat: use single fs element and load different vis into it
99c8983
@jenniferarnesen
feat: sizing of the iframe as well as positioning of the nav buttons …
aa5bf33 
…[skip ci]
@jenniferarnesen
chore: remove props no longer used
7116a28
@jenniferarnesen
chore: override display for LL
2c79ce3
@jenniferarnesen
chore: fs for LL items
41ffd12
@jenniferarnesen
fix: only show Slideshow if fullscreen allowed in sys settings
609b249
@jenniferarnesen
fix: filter out SPACER and MESSAGES items from sorted items list
8c08c6a
@jenniferarnesen
feat: styling and show/hide controls
3df05ba
@jenniferarnesen
Merge branch 'master' into feat/slide-show-display-none
5765c9b
@jenniferarnesen
Merge branch 'master' into feat/slide-show-display-none
2a6bd82
@jenniferarnesen
chore: fix jest tests
0934590
@jenniferarnesen
feat: add exit button and always show controls on hover
ed77aac
@jenniferarnesen
chore: consistent class names
6c4e86b
@jenniferarnesen
fix: always show fs controls at bottm
540377c
@jenniferarnesen
fix: persistent nav bar
63a33a1
@jenniferarnesen
Merge branch 'master' into feat/slide-show-display-none
cada906
@cooper-joe
fix: slideshow control bar styles
a25b0d6
@jenniferarnesen
fix: text item style
4d8f8df
@jenniferarnesen
chore: move fullscreen handling to a hook
021a6de
@jenniferarnesen
chore: renaming vars
34a643a
@jenniferarnesen
fix: force load when in fullscreen
6d70db5
@jenniferarnesen
fix: add controls buffer to App items
ff6b76a
@jenniferarnesen
chore: slideshow button tooltip and refactor fs enabled on types
78d9280
@jenniferarnesen
fix: remove padding around items when in fullscreen
642f5ec
@jenniferarnesen
chore: update comment
d447245
jenniferarnesen and others added 26 commits December 4, 2024 12:25
@jenniferarnesen
fix: set height of slideshow controlbar to 40px
f3985b5
@jenniferarnesen
fix: set height on slideshow grid to prevent growing controlbar on hi…
b1855a6 
…gh res screen
@jenniferarnesen
fix: disable slideshow button when offline and not cached
caf0e6b
@jenniferarnesen
fix: show nav buttons as disabled when only one item
b6573bf
@jenniferarnesen
fix: add background color to fs element to avoid brief flashing of black
8043cfc
@jenniferarnesen
fix: do not tab to invisible elements
286fd89
@jenniferarnesen
fix: more tweaking to get transition to slideshow bg colors right
24888cd
@jenniferarnesen
Merge branch 'master' into feat/slide-show-display-none
f1fc4c8
@jenniferarnesen
fix: tabIndex is a string not a number
9f4906f
@jenniferarnesen
fix: messages item scrollbar was missing
347e520
@jenniferarnesen
fix: display message on unloaded items when offline and not cached
df0fda2
@jenniferarnesen
feat: filter badges
b01cfa4
@jenniferarnesen
fix: with flex external container needed to prevent button from takin…
e38ecf5 
…g all space
@jenniferarnesen
feat: add tooltip to filter badge - not working yet
b2d7937
@HendrikThePendric
feat: show all filters in a popover when clicking a button with total…
a01587e 
… filter count
@jenniferarnesen
fix: use string pluralization and remove unneeded style
2dce45e
@jenniferarnesen
fix: show different message when single filter
c5eb94a
@jenniferarnesen
fix: use correct prop in i18n
0c5f5e8
@jenniferarnesen
chore: temporary to get a build
ecc63aa
@jenniferarnesen
test: add cypress test that navigates backwards to start
6e7071a
@jenniferarnesen
fix: remove tabbing when element not visible during slideshow
11e1f8c
@jenniferarnesen
fix: nav buttons and page counter should maintain ltr
26ab9fa
@cooper-joe
fix: slideshow filter content and style
524c937
@jenniferarnesen
Merge branch 'feat/slide-show-display-none' of github.com:dhis2/dashb…
9870891 
…oard-app into feat/slide-show-display-none
@jenniferarnesen
fix: rtl navigation according to Gassim
e7ceb68
@jenniferarnesen
fix: the arrow buttons also must respect ltr or rtl
d42f7dd
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-3172.dashboard.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify December 19, 2024 14:14 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jenniferarnesen @dhis2-bot @cooper-joe @HendrikThePendric