Skip to content

feat: release DHIS2-18441 and DHIS2-13038 #2860

feat: release DHIS2-18441 and DHIS2-13038

feat: release DHIS2-18441 and DHIS2-13038 #2860

Triggered via pull request January 8, 2025 09:11
Status Failure
Total duration 1m 36s
Artifacts

dhis2-verify-commits.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 12 warnings
lint-commits
You have commit messages with errors ⧗ input: feat: maximize use of the available screen space by reducing whitespace in the dashboard item grid (#3165) Implements part of DHIS2-18441 Note that these changes are not included in the design doc --- ### Key features 1. Reduces whitespace in the dashboard item grid 2. Adjusts layout when a scrollbar appears --- ### Description In this PR we adjust the overall grid styles a bit to allow dashboard-items to be a little bit closer together. Additionally we wanted to solve the problem that our grid layout didn't take the presence/absence of a scrollbar into account. Before we simply had reserved sufficient margin on the right so that things would still look OK and function correctly when a scrollbar was present. In this PR an additional container was added which does not scroll and thus will reduce in width when its parent gets a scrollbar. Because it has a `ResizeObserver` attached to the DOM element we can monitor when this happens and trigger a state change. We've done this using a Provider/Consumer and a hook so that descendants can easily access this state. --- ### References JIRA issue DHIS2-18441: https://dhis2.atlassian.net/browse/DHIS2-18441 Design doc: https://docs.google.com/document/d/1c8Ll1aLbFYwU8HYsyDlH1wk_QKTrUXwNanCiqayczOM ✖ header must not be longer than 100 characters, current length is 106 [header-max-length] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
lint-pr-title
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
lint-pr-title
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
lint-pr-title
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
lint-pr-title
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
lint-pr-title
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
lint-pr-title
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
lint-commits
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
lint-commits
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
lint-commits
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
lint-commits
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
lint-commits
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
lint-commits
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/