Upgrades Puppeteer to 8.0.0.

The current version seems to have issues with NPM 7 and does not automatically download Chromium. 8.0.0 seems to work as expected though. This is also just a general upgrade since they apparently released 3 versions with breaking changes in the last few months.
dgp1130 · Apr 19, 2021 · 61f2fc8 · 61f2fc8
1 parent d32c0e8
commit 61f2fc8
Show file tree

Hide file tree

Showing 12 changed files with 53 additions and 96 deletions.
diff --git a/common/testing/BUILD.bazel b/common/testing/BUILD.bazel
@@ -177,7 +177,7 @@ ts_library(
     deps = [
         ":effects",
         "@npm//@types/node",
-        "@npm//@types/puppeteer",
+        "@npm//puppeteer",
     ],
 )
 
@@ -191,13 +191,12 @@ ts_library(
         ":puppeteer",
         "@npm//@types/jasmine",
         "@npm//@types/node",
-        "@npm//@types/puppeteer",
+        "@npm//puppeteer",
     ],
 )
 
 jasmine_node_test(
     name = "puppeteer_test",
-    data = ["@npm//puppeteer"],
     deps = [":puppeteer_test_lib"],
 )
 

diff --git a/examples/components/BUILD.bazel b/examples/components/BUILD.bazel
@@ -59,9 +59,6 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    data = [
-        ":devserver",
-        "@npm//puppeteer",
-    ],
+    data = [":devserver"],
     deps = [":test_lib"],
 )
diff --git a/examples/custom_bundling/BUILD.bazel b/examples/custom_bundling/BUILD.bazel
@@ -82,9 +82,6 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    data = [
-        ":devserver",
-        "@npm//puppeteer",
-    ],
+    data = [":devserver"],
     deps = [":test_lib"],
 )
diff --git a/examples/data/BUILD.bazel b/examples/data/BUILD.bazel
@@ -34,9 +34,6 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    data = [
-        ":devserver",
-        "@npm//puppeteer",
-    ],
+    data = [":devserver"],
     deps = [":test_lib"],
 )
diff --git a/examples/minimal/BUILD.bazel b/examples/minimal/BUILD.bazel
@@ -44,9 +44,6 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    data = [
-        ":devserver",
-        "@npm//puppeteer",
-    ],
+    data = [":devserver"],
     deps = [":test_lib"],
 )
diff --git a/examples/multi_page/BUILD.bazel b/examples/multi_page/BUILD.bazel
@@ -49,10 +49,7 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    data = [
-        ":devserver",
-        "@npm//puppeteer",
-    ],
+    data = [":devserver"],
     deps = [":test_lib"],
 )
 

diff --git a/examples/resources/BUILD.bazel b/examples/resources/BUILD.bazel
@@ -47,9 +47,6 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    data = [
-        ":devserver",
-        "@npm//puppeteer",
-    ],
+    data = [":devserver"],
     deps = [":test_lib"],
 )
diff --git a/examples/scripts/BUILD.bazel b/examples/scripts/BUILD.bazel
@@ -36,9 +36,6 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    data = [
-        ":devserver",
-        "@npm//puppeteer",
-    ],
+    data = [":devserver"],
     deps = [":test_lib"],
 )
diff --git a/examples/site/home/BUILD.bazel b/examples/site/home/BUILD.bazel
@@ -29,15 +29,11 @@ ts_library(
         "//common/testing:devserver",
         "//common/testing:puppeteer",
         "@npm//@types/jasmine",
-        "@npm//@types/puppeteer",
     ],
 )
 
 jasmine_node_test(
     name = "home_test",
-    data = [
-        ":home_devserver",
-        "@npm//puppeteer",
-    ],
+    data = [":home_devserver"],
     deps = [":home_test_lib"],
 )
diff --git a/examples/styles/BUILD.bazel b/examples/styles/BUILD.bazel
@@ -31,9 +31,6 @@ ts_library(
 
 jasmine_node_test(
     name = "test",
-    data = [
-        ":devserver",
-        "@npm//puppeteer",
-    ],
+    data = [":devserver"],
     deps = [":test_lib"],
 )
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -51,11 +51,10 @@
         "@bazel/typescript": "^3.0.0",
         "@types/jasmine": "^3.6.2",
         "@types/node": "^14.14.13",
-        "@types/puppeteer": "^5.4.2",
         "@types/yargs": "^15.0.11",
         "http-status-codes": "^2.1.4",
         "jasmine": "^3.6.3",
-        "puppeteer": "^5.5.0",
+        "puppeteer": "^8.0.0",
         "tree-kill": "^1.2.2",
         "typescript": "^3.9.7"
     },