Allow Unsupported platforms to run, when Environment variables are set. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move platform check and Error into resolveEmbeddedGitDir, so if the Environment variable 'LOCAL_GIT_DIRECTORY' is set, Unsupported platforms are still able to run. Change path.join to set git-core and git to be if win32 else 'others'
… configuring environment in Windows'
|
@shiftkey Ping! Is there anything i can do to help this along? |
|
@adamsteen not really, just lacking bandwidth on my end to ponder the overall changes and ensure they don't affect the supported platforms. I've got an open issue on the native toolchain to support FreeBSD desktop/dugite-native#82 and we use Docker to build Git for ARM64 already so I'd love for someone more familiar with that flavour of OS to see if we can support that. Would proper OpenBSD support help here, which is a way off, or are you just interested in the escape hatch? |
|
@shiftkey proper OpenBSD would work also, but really i just want dugite to work in surf on OpenBSD so i can get CI setup. |
shiftkey
approved these changes
Aug 31, 2018
|
@adamsteen this has been published to NPM as |
|
@shiftkey thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I develop on OpenBSD and one of the packages i have taken an interest in, uses surf for continuous integration, relying on dugite for git support.
When i initially looked at the problem i thought i could set
GIT_EXEC_PATHandLOCAL_GIT_DIRECTORYand things might work, but i hit somethrow new Error('Git not supported on platform: ' + process.platform)errors.With these changes and when the environment variables are set, the
Git not supported on platformare not hit and dugite uses my installed git package, with the environment variables not set there is no functionally change.I did the following changed.
Move platform check and Error into resolveEmbeddedGitDir, so if the
Environment variable 'LOCAL_GIT_DIRECTORY' is set, the error
throw new Error('Git not supported on platform: ' + process.platform)is still executed.Change path.join to set git-core and git to be if win32 else 'others' (with others being Unixes)
I didn't want to just target OpenBSD as i know of other developments using FreeBSD will also be impacted.
I know OpenBSD (and FreeBSD) are not supported and don't expect support, but by having these changes unsupported platforms have a chance of running.
[Edit] I have tested this change on OpenBSD and Windows.