Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yara yls support #4886

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

TcM1911
Copy link

@TcM1911 TcM1911 commented Dec 28, 2024

This adds Yara support to ALE using Avast's language server for yara:
https://avast.github.io/yls/

A .git folder is used to determine the project_root so this means the
Yara rules must be in a git repo for the integration to work.

The server only have 1 optional argument (-v, --verbose). Since this is
the case, no additional configuration options are available.

This adds Yara support to ALE using Avast's language server for yara:
https://avast.github.io/yls/

A ".git" folder is used to determine the project_root so this means the
Yara rules must be in a git repo for the integration to work.

The server only have 1 optional argument (-v, --verbose). Since this is
the case, no additional configuration options are available.
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry for the new linter in doc/ale-supported-languages-and-tools.txt file and this is missing a callback function to handle the linter output.

@TcM1911
Copy link
Author

TcM1911 commented Dec 30, 2024

@hsanson, I've added an entry to doc/ale-supported-languages-and-tools.txt. With regards to the "missing callback" function, I don't know what you are referring to. I'm not seeing any references to it in the dev doc. I used Zig zls as a template for this implementation. So with regards to tests, the yls linter tests are essentially testing the same as the linter tests for zls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants