Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading BigInt rustdoc #1379

Merged
merged 3 commits into from
Feb 3, 2024

Conversation

guillaumebort
Copy link
Contributor

The original documentation was unclear about the value of the bool. I interpreted it as being true if the value was truncated.

The original documentation was unclear about the value of the bool. I interpreted it as being `true` if the value was truncated.
@guillaumebort guillaumebort force-pushed the guillaume.bort/0kCifch branch from c762fd3 to 3bfb859 Compare January 5, 2024 12:39
src/bigint.rs Outdated Show resolved Hide resolved
src/bigint.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mmastrac mmastrac enabled auto-merge (squash) February 3, 2024 17:24
@mmastrac mmastrac merged commit 477f5af into denoland:main Feb 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants