feat(Seq)!: Add sequenceResultA, align sequenceResultM #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
force-pushed
the
array-sequence
branch
2 times, most recently
from
4a13d62 to
f23dd0e
Compare
Closed
bartelink
changed the title
|
Open to removing anything you consider an overstep - I'm not enjoying the fantomas ruleset so there is some letter of the law interpretations. Please push back on anything that's not right! have not actually fsi'd the doc samples, or looked at the gitbook |
bartelink
force-pushed
the
array-sequence
branch
from
93115e8 to
b8cab35
Compare
bartelink
force-pushed
the
array-sequence
branch
from
b8cab35 to
b254b92
Compare
bartelink
commented
Feb 15, 2024
bartelink
commented
Feb 15, 2024
bartelink
commented
Feb 15, 2024
TheAngryByrd
requested changes
Feb 15, 2024
as mentioned in #254 I'm happy either way. Adding it is not time-sensitive for me, so I'll leave it entirely up to you whether you want I guess my slight preference is to stay with one PR, but I'm a maintainer too so I'd prefer you to make the call. |
bartelink
force-pushed
the
array-sequence
branch
from
99d629a to
3b71915
Compare
bartelink
force-pushed
the
array-sequence
branch
2 times, most recently
from
3a5fe58 to
d088226
Compare
bartelink
commented
Feb 15, 2024
| @@ -4,10 +4,12 @@ | |||
| <OutputType>Exe</OutputType> | |||
| <TargetFramework>net7.0</TargetFramework> | |||
| <IsPackable>false</IsPackable> | |||
| <!-- <NoWarn>NU1904</NoWarn>--> | |||
| <TreatWarningsAsErrors>false</TreatWarningsAsErrors> | |||
There was a problem hiding this comment.
there's a new vulnerability that breaks the build
I see you have 1903 in the build props - if you fix that, I'l rebase off that as its obv not ideal to have this in the PR
|
The build wasn't happy for reasons I could not discern - happy to rebase or adjust this any time; just ping |
TheAngryByrd
pushed a commit
that referenced
this pull request
Dec 7, 2024
* Roll on '24 * refactor(Seq.sequenceResultM)!: Change Ok to Array * docs: sequenceResultM * feat(Seq): sequenceResultA * f sequenceResultM docs * Supress compile error * Fix proposed version
TheAngryByrd
added a commit
that referenced
this pull request
Dec 7, 2024
* Remove Ply and update to FSharp 6 (#248) * remove Ply and update to FSharp 6 * Cleanup dependencies * Fix fsharp.core warning * Don't build so much * Asyncinterfaces (#250) * use Microsoft.Bcl.AsyncInterfaces * Updated IcedTasks to 0.11.0 * Fix for fable * Net8 (#251) * net8 tfm * Update README * Fix CI cancellation issues * Build on macos-14 * 205 overload resolution (#252) * Missed this in net8 additions * Fix overload resolution issues in Core * Fix overload resolution issues in Tasks/Hopac * Fix overload resolution issues in CancellableTaskResult * WIP: TaskValidtionCE * Wip merge sources * Fix MergeSources for CTValidation * cleanup * Ensure IAsyncDisposable tests * ignore nuget stuff * feat(Seq)!: Add sequenceResultA, align sequenceResultM (#255) * Roll on '24 * refactor(Seq.sequenceResultM)!: Change Ok to Array * docs: sequenceResultM * feat(Seq): sequenceResultA * f sequenceResultM docs * Supress compile error * Fix proposed version * Cleanup build * 209 remove MergeSources (and!) from some implementations (#261) * Remove MergeSources from resultCE * Remove MergeSources from AsyncResult * Remove MergeSources from ResultOption * Fixup resultOption docs * Remove MergeSources from OptionCE * Remove MergeSources from ValueOptionCE * remove MergeSources Option/ValueOption * MSBuild.StructuredLogger update * disable binlog for fake * Many updates * fix residual rebase artifacts * Merge TaskResult into Core lib (#285) * silence FS3511 --------- Co-authored-by: Ruben Bartelink <[email protected]>
TheAngryByrd
added a commit
that referenced
this pull request
Dec 7, 2024
- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd - BREAKING: [Remove MergeSources (and!) from some implementations](#261) Credits @TheAngryByrd - BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd - This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library. - [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd - [Build against Net8](#251) Credits @TheAngryByrd - [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd - [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink - [feat(Seq): sequenceResultA](#255) Credits @bartelink -
TheAngryByrd
added a commit
that referenced
this pull request
Dec 21, 2024
- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd - BREAKING: [Remove MergeSources (and!) from some implementations like Result](#261) Credits @TheAngryByrd - BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd - This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library. - BREAKING: [Rename retn to singleton](#287) Credits @1eyewonder - [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd - [Build against Net8](#251) Credits @TheAngryByrd - [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd - [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink - [feat(Seq): sequenceResultA](#255) Credits @bartelink - [Updated uses of Seq.append](#290) Credits @1eyewonder -
TheAngryByrd
added a commit
that referenced
this pull request
Jan 6, 2025
- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd - BREAKING: [Remove MergeSources (and!) from some implementations like Result](#261) Credits @TheAngryByrd - BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd - This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library. - BREAKING: [Rename retn to singleton](#287) Credits @1eyewonder - [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd - [Build against Net8](#251) Credits @TheAngryByrd - [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd - [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink - [feat(Seq): sequenceResultA](#255) Credits @bartelink - [Updated uses of Seq.append](#290) Credits @1eyewonder - [Add Option.traverseAsync and Option.sequenceAsync](#298 (comment)) Credits @tw0po1nt - [Add Require and Check helper methods](#295) Credits @PI-Gorbo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #254
Seq.sequenceResultAsequenceResultMwith that ofsequenceResultA(yield an Array, rather than accumulating in alistand upcasting viaList.toSeqsequenceResultM