Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: simplifie la projection des colonnes #11226

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LeSim
Copy link
Member

@LeSim LeSim commented Jan 20, 2025

super seed #11041

  • introduit CellComponent pour afficher une la projection d'une colonne sur un dossier.

RAF:

  • le faire marcher avec les streams
  • comparaison du rendu sur l'ensemble des champs
  • comparaison du nombre de requêtes sql
    • inclure les attachments avec les champs (?)
  • gérer le cas dossier.hidden_by_user_at.present?

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 3.12500% with 93 lines in your changes missing coverage. Please review.

Project coverage is 33.81%. Comparing base (7462bc4) to head (d75a13a).

Files with missing lines Patch % Lines
app/components/instructeurs/cell_component.rb 0.00% 65 Missing ⚠️
app/services/dossier_projection_service.rb 0.00% 22 Missing ⚠️
app/helpers/dossier_helper.rb 16.66% 5 Missing ⚠️
.../controllers/instructeurs/procedures_controller.rb 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (7462bc4) and HEAD (d75a13a). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (7462bc4) HEAD (d75a13a)
10 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #11226       +/-   ##
===========================================
- Coverage   84.41%   33.81%   -50.61%     
===========================================
  Files        1200     1201        +1     
  Lines       26380    32336     +5956     
  Branches     4965     3347     -1618     
===========================================
- Hits        22269    10933    -11336     
- Misses       4111    21403    +17292     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant