Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Tests Coverage for System attribute resource #272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updating Tests Coverage for System attribute resource #272

wants to merge 1 commit into from
+216 −22

Conversation

Bhavneet-Sharma
Copy link

SUMMARY

Added new testcases to improve the UT and AT coverage for redfish_dell_system_attribute resource

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Resource: Redfish Dell System Attribute

ADDITIONAL INFORMATION

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Screenshot 2025-01-13 170528
Screenshot 2025-01-13 170623
Screenshot 2025-01-13 170640
Screenshot 2025-01-13 170657
Screenshot 2025-01-13 170706
Screenshot 2025-01-13 170721
Screenshot 2025-01-13 170734
Screenshot 2025-01-13 170745

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

@terraform-providers-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@Bhavneet-Sharma Bhavneet-Sharma self-assigned this Jan 13, 2025
@Bhavneet-Sharma Bhavneet-Sharma marked this pull request as ready for review January 14, 2025 08:58
@Bhavneet-Sharma Bhavneet-Sharma requested a review from a team as a code owner January 14, 2025 08:58
@Bhavneet-Sharma
Copy link
Author

run e2e test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapana05 sapana05 Awaiting requested review from sapana05

@taohe1012 taohe1012 Awaiting requested review from taohe1012

@MangirishK MangirishK Awaiting requested review from MangirishK

@Krunal-Thakkar Krunal-Thakkar Awaiting requested review from Krunal-Thakkar

@meenakshidembi691 meenakshidembi691 Awaiting requested review from meenakshidembi691

At least 2 approving reviews are required to merge this pull request.

Assignees

@Bhavneet-Sharma Bhavneet-Sharma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bhavneet-Sharma @terraform-providers-svc