1.1.2 Functional Test Fix (#108)

- When reading all of the volumes or volume snapshots in there
  respective datasources. If the array is used heavly sometimes there
  are stale ids. For these cases we should ignore the error and return
  what we can.

powerstore/datasource_volume.go

@@ -19,6 +19,7 @@ package powerstore
 
 import (
 	"context"
+	"strings"
 	"terraform-provider-powerstore/client"
 	"terraform-provider-powerstore/models"
 
@@ -431,13 +432,25 @@ func updateVolumeState(volumes []gopowerstore.Volume, p *client.Client) (respons
 		size, unit := convertFromBytes(volumeValue.Size)
 		hostMapping, err := p.PStoreClient.GetHostVolumeMappingByVolumeID(context.Background(), volumeValue.ID)
 		if err != nil {
+			// Ignore the error if the volume cannot be found by id. Instead just continue.
+			// This could be a failure that happens with alot of volumes and stale ids are in the cache.
+			// In this case we should still return all volumes that are valid to the user
+			if strings.Contains(err.Error(), "was not found.") {
+				continue
+			}
 			return nil, err
 		}
 		if len(hostMapping) > 0 {
 			hostID, hostGroupID, logicalUnit = hostMapping[0].HostID, hostMapping[0].HostGroupID, hostMapping[0].LogicalUnitNumber
 		}
 		volGroupMapping, err := p.PStoreClient.GetVolumeGroupsByVolumeID(context.Background(), volumeValue.ID)
 		if err != nil {
+			// Ignore the error if the volume cannot be found by id. Instead just continue.
+			// This could be a failure that happens with alot of volumes and stale ids are in the cache.
+			// In this case we should still return all volumes that are valid to the user
+			if strings.Contains(err.Error(), "was not found.") {
+				continue
+			}
 			return nil, err
 		}
 		if len(volGroupMapping.VolumeGroup) > 0 {