move kernel_prerm.d logic into dkms #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use a flag file for tracking the pending state since unbuild_module gets run in a subshell
this is already performed by dkms_autoinstaller
logic that involves enumerating dkms modules or kernel versions should not be duplicated outside of dkms
autoinstall still produces a lot of output per module, but getting the current module name was only possible from messages appearing after slow tasks (e.g. build) have finished, and it was still mostly guessing
|
Thanks! Will perform all the necessary tests on Red Hat / SUSE systems this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds two new actions
kernel_postinst(a wrapper for autoinstall) andkernel_prermthat are intended to be called fromkernel_*.d/dkmsto move the prerm logic into dkms as wellI haven't done proper testing of the integration bits (the kernel_*.d changes) yet in my Debian dkms torture chroots, yet, and I won't be able to do them for the redhat side
naming etc. is open for discussion