Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/locust]: Updates locust version, adds fix for web-login, adds ability to pass reserved ip to load balancer service #625

Merged

Conversation

byronmansfield
Copy link
Contributor

Description

Updated the image version to the latest. Added in a fix for web-login argument. Adds ability to pass in a kubernetes attribute `loadBalancerIP` to the master service if it's type `LoadBalancer` so that you can attach a reserved IP to it if you wanted to.

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@byronmansfield byronmansfield marked this pull request as ready for review November 6, 2024 23:01
@byronmansfield byronmansfield requested a review from a team as a code owner November 6, 2024 23:01
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @byronmansfield 💜

@max-rocket-internet max-rocket-internet enabled auto-merge (squash) November 7, 2024 08:57
@byronmansfield byronmansfield changed the title stable/locust: Updates locust version, adds fix for web-login, adds ability to pass reserved ip to load balancer service [stable/locust]: Updates locust version, adds fix for web-login, adds ability to pass reserved ip to load balancer service Nov 7, 2024
auto-merge was automatically disabled November 7, 2024 14:20

Head branch was pushed to by a user without write access

@byronmansfield
Copy link
Contributor Author

You're welcome @max-rocket-internet. Sorry about the failed jobs. I was using it on my latest job and saw a few things that would be helpful. 👍

@max-rocket-internet max-rocket-internet enabled auto-merge (squash) November 7, 2024 14:40
@max-rocket-internet max-rocket-internet merged commit 7eb5025 into deliveryhero:master Nov 7, 2024
5 checks passed
@byronmansfield
Copy link
Contributor Author

@max-rocket-internet how long before this new helm chart version gets published?

@max-rocket-internet
Copy link
Member

@byronmansfield
Copy link
Contributor Author

Oh I guess I mean for me to be able to pull it from helm's repositories. Not docker.

Ran just now

$ helm repo update
Hang tight while we grab the latest from your chart repositories...
...
...Successfully got an update from the "deliveryhero" chart repository
...
Update Complete. ⎈Happy Helming!⎈
$ helm search repo deliveryhero/locust --versions | head -n 5
NAME                    CHART VERSION   APP VERSION     DESCRIPTION
deliveryhero/locust     0.31.6          2.15.1          A chart to install Locust, a scalable load test...
deliveryhero/locust     0.31.5          2.15.1          A chart to install Locust, a scalable load test...
deliveryhero/locust     0.31.4          2.15.1          A chart to install Locust, a scalable load test...
deliveryhero/locust     0.31.3          2.15.1          A chart to install Locust, a scalable load test...

@max-rocket-internet
Copy link
Member

Oh I guess I mean for me to be able to pull it from helm's repositories

This is deprecated now, OCR images are the way:

helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/locust --version 0.31.7

@byronmansfield byronmansfield deleted the locust-updates branch November 8, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants