[stable/wiremock] Add serviceAccount #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-rocket-internet
approved these changes
Oct 3, 2024
|
@max-rocket-internet Should I update the README.md? There has been a mistake in the alphabetical order I guess. |
|
@turuncuofke just run this from repo root (in your branch) and commit the changes: |
auto-merge was automatically disabled
October 4, 2024 08:35
Head branch was pushed to by a user without write access
turuncuofke
force-pushed
the
wiremock-add-serviceaccount
branch
from
5538f25 to
c5dc1fd
Compare
fekaiser
pushed a commit
to gastromatic/delivery-hero-helm-charts
that referenced
this pull request
Oct 23, 2024
* [stable/wiremock] Add serviceAccount * Fix README.md --------- Co-authored-by: Max Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability of creating a service account resource with custom annotations for the wiremock consumer pod.
Since we are using large stubs files for our mock tests and we are constantly updating those large files, it is the best solution for us to upload those files in to an s3 bucket and copy them to our wiremock consumer pod using an init container. To be able to this, we need some kind of authorization and authentication mechanism for our aws account. And using a service account for this suits us perfectly. Because of those reasons, related updates were made on the wiremock helm chart. All kinds of feedbacks are appreciated. Thanks in advance.
serviceaccount.yaml is created
template.spec.serviceAccount filed is added to deployment.yaml
serviceAccount field is added to values.yaml file to control related resources
Title of the PR starts with chart name (e.g.
[stable/mychartname])I have read the contribution instructions, bumped chart version and regenerated the docs
Github actions are passing