[stable/kube-downscaler] Kube-Downscaler does not respect release namespace when templating #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `kube-downscaler` helm chart doesn't honor the namespace passed in to helm. This is because the chart is missing the typical metadata configuration on its kubernetes resources. ie, this problem is the same as this one for another chart: deliveryhero#216 To reproduce this problem: ```bash helm fetch deliveryhero/kube-downscaler --version 0.7.4 --untar=true helm template my-release kube-downscaler --namespace kube-systen > kube-downscaler.yaml ``` The `deployment.yaml` and other files will have no namespace. ie, it is not configured here: https://github.com/deliveryhero/helm-charts/blob/0b420820e3f88d5e7f9f10ddd1c9a029adb9a422/stable/kube-downscaler/templates/deployment.yaml#L3 Fix is as below: ```yaml apiVersion: apps/v1 kind: Deployment metadata: name: "{{ $fullname }}-{{ .name }}" namespace: {{ .Release.Namespace }} ```
hlascelles
changed the title
|
@hlascelles there was a checklist of items that are required to make a PR mergeable that you deleted when you opened the PR 😃 https://github.com/deliveryhero/helm-charts/blob/master/.github/pull_request_template.md#checklist |
|
Nice! Hmm, that doc regenerate wiped out a lot. Is that right? |
Not right, you need to run it from repo root |
max-rocket-internet
approved these changes
Sep 17, 2024
fekaiser
pushed a commit
to gastromatic/delivery-hero-helm-charts
that referenced
this pull request
Oct 23, 2024
…espace when templating (deliveryhero#601) * Kube-Downscaler does not respect release namespace when templating The `kube-downscaler` helm chart doesn't honor the namespace passed in to helm. This is because the chart is missing the typical metadata configuration on its kubernetes resources. ie, this problem is the same as this one for another chart: deliveryhero#216 To reproduce this problem: ```bash helm fetch deliveryhero/kube-downscaler --version 0.7.4 --untar=true helm template my-release kube-downscaler --namespace kube-systen > kube-downscaler.yaml ``` The `deployment.yaml` and other files will have no namespace. ie, it is not configured here: https://github.com/deliveryhero/helm-charts/blob/0b420820e3f88d5e7f9f10ddd1c9a029adb9a422/stable/kube-downscaler/templates/deployment.yaml#L3 Fix is as below: ```yaml apiVersion: apps/v1 kind: Deployment metadata: name: "{{ $fullname }}-{{ .name }}" namespace: {{ .Release.Namespace }} ``` * Bump version for change * Regenerate docs * Regenerate docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
kube-downscalerhelm chart doesn't honour the namespace passed in to helm. This is because the chart is missing the typical metadata configuration on its kubernetes resources. ie, this problem is the same as this one for another chart: #216To reproduce this problem:
helm fetch deliveryhero/kube-downscaler --version 0.7.4 --untar=true helm template my-release kube-downscaler --namespace kube-system > kube-downscaler.yamlThe
deployment.yamland other files will have no namespace. ie, it is not configured here:helm-charts/stable/kube-downscaler/templates/deployment.yaml
Line 3 in 0b42082
Fix is as below for the required resources:
Checklist
[stable/mychartname])