Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/aws-s3-proxy] Sync labels btw pod and deployment #588

Merged
merged 3 commits into from
Jul 1, 2024
Merged

[stable/aws-s3-proxy] Sync labels btw pod and deployment #588

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da0f490
sync labes between deployment and pod
BlueHorn07 Jun 30, 2024
220b754
bump chart version to 0.1.5
BlueHorn07 Jun 30, 2024
1fad601
revert matchLabels changes
BlueHorn07 Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/aws-s3-proxy/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ description: |
See here for configuration via environment variables: https://github.com/pottava/aws-s3-proxy#usage
name: aws-s3-proxy
home: https://github.com/pottava/aws-s3-proxy
version: 0.1.4
version: 0.1.5
maintainers:
- name: max-rocket-internet
email: [email protected]
2 changes: 1 addition & 1 deletion stable/aws-s3-proxy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# aws-s3-proxy

![Version: 0.1.4](https://img.shields.io/badge/Version-0.1.4-informational?style=flat-square) ![AppVersion: 2.0](https://img.shields.io/badge/AppVersion-2.0-informational?style=flat-square)
![Version: 0.1.5](https://img.shields.io/badge/Version-0.1.5-informational?style=flat-square) ![AppVersion: 2.0](https://img.shields.io/badge/AppVersion-2.0-informational?style=flat-square)

Reverse proxy for AWS S3 with basic authentication.

Expand Down
6 changes: 2 additions & 4 deletions stable/aws-s3-proxy/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,11 @@ spec:
replicas: {{ .Values.replicaCount }}
selector:
matchLabels:
app.kubernetes.io/name: {{ include "aws-s3-proxy.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
{{ include "aws-s3-proxy.labels" . | indent 6 }}
Copy link
Member

@max-rocket-internet max-rocket-internet Jul 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this part should change as selector labels are immutable and shouldn't be treated like the other labels 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for your comment!

Are you suggesting that the changes to matchLabels might cause breaking changes? If that’s the case, I’ll revert the changes to matchLabels. 🙏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, they are immutable, you can't change them without deleting and recreating the resource. So I would just not change this part.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reverted it. Thanks for pointing it out and for your kind review! 😄

template:
metadata:
labels:
app.kubernetes.io/name: {{ include "aws-s3-proxy.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
{{ include "aws-s3-proxy.labels" . | indent 8 }}
spec:
{{- with .Values.imagePullSecrets }}
imagePullSecrets:
Expand Down
Loading