Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/node-local-dns] add prefetch options to configuration #586

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

andrii29
Copy link
Contributor

Description

add ability to enable prefetch

prefetch will prefetch popular items when they are about to be expunged from the cache. Popular means AMOUNT queries have been seen with no gaps of DURATION or more between them. DURATION defaults to 1m. Prefetching will happen when the TTL drops below PERCENTAGE, which defaults to 10%, or latest 1 second before TTL expiration. Values should be in the range [10%, 90%]. Note the percent sign is mandatory. PERCENTAGE is treated as an int.

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@andrii29 andrii29 requested a review from a team as a code owner June 19, 2024 06:20
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting feature, thanks @andrii29 💜

@max-rocket-internet max-rocket-internet merged commit c827e43 into deliveryhero:master Jun 19, 2024
5 checks passed
@andrii29 andrii29 deleted the prefetch branch June 19, 2024 08:57
fekaiser pushed a commit to gastromatic/delivery-hero-helm-charts that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants