[stable/node-local-dns] Update bindIp description #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,7 @@ config: | |||
| # Use a custom upstreamsvc for -upstreamsvc | |||
| customUpstreamsvc: "" | |||
|
|
|||
| # If true, it will bind 0.0.0.0, otherwise dnsServer and localDns will be used. https://github.com/bottlerocket-os/bottlerocket/issues/3711#issuecomment-1907087528 | |||
There was a problem hiding this comment.
@Sarga you wrote this, care to comment? Is this change valid?
There was a problem hiding this comment.
@max-rocket-internet @andrii29
The changes are correct, it was my mistake. Thanks a million for noticing and correcting it!
andrii29
changed the title
max-rocket-internet
approved these changes
Jun 18, 2024
max-rocket-internet
merged commit c559dd5
into
deliveryhero:master
5 of 6 checks passed
fekaiser
pushed a commit
to gastromatic/delivery-hero-helm-charts
that referenced
this pull request
Oct 23, 2024
* Update values.yaml * regenerate docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
[stable/mychartname])