fix: resolution modules can only update the dispute's status forward #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xShaito
approved these changes
Dec 11, 2024
ashitakah
requested changes
Dec 16, 2024
| @@ -313,6 +313,11 @@ contract Oracle is IOracle, OracleAccessController { | |||
| if (msg.sender != _request.disputeModule && msg.sender != _request.resolutionModule) { | |||
| revert Oracle_NotDisputeOrResolutionModule(msg.sender); | |||
| } | |||
|
|
|||
| if (msg.sender == _request.resolutionModule && _status <= DisputeStatus.Escalated) { | |||
There was a problem hiding this comment.
Its true that <= is a very good solution to optimize, but what if we add new dispute status. IDK , for now is fine I guess
There was a problem hiding this comment.
Before adding a new state, we'd have to ensure the change is fully compatible with all existing modules and their respective flows. This will definitely be a pain point in future developments.
In this PR I specifically adhere to what the auditor found: a poorly implemented module could reverse the state of a dispute to a previous state, which is unexpected and could break an invariant (is it really an invariant? I don't think we have defined them yet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes OPT-565