Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change mapping variable names in favor of clarity #63

Open
wants to merge 2 commits into
base: fix/oz-audit
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions solidity/contracts/Oracle.sol
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ contract Oracle is IOracle, OracleAccessController {
mapping(bytes32 _requestId => uint256 _finalizedAt) public finalizedAt;

/// @inheritdoc IOracle
mapping(bytes32 _id => uint256 _requestCreatedAt) public requestCreatedAt;
mapping(bytes32 _requestId => uint256 _requestCreatedAt) public requestCreatedAt;

/// @inheritdoc IOracle
mapping(bytes32 _id => uint256 _responseCreatedAt) public responseCreatedAt;
mapping(bytes32 _responseId => uint256 _responseCreatedAt) public responseCreatedAt;

/// @inheritdoc IOracle
mapping(bytes32 _id => uint256 _disputeCreatedAt) public disputeCreatedAt;
mapping(bytes32 _disputeId => uint256 _disputeCreatedAt) public disputeCreatedAt;

/// @inheritdoc IOracle
mapping(bytes32 _responseId => bytes32 _disputeId) public disputeOf;
Expand All @@ -35,7 +35,7 @@ contract Oracle is IOracle, OracleAccessController {
mapping(bytes32 _disputeId => DisputeStatus _status) public disputeStatus;

/// @inheritdoc IOracle
mapping(uint256 _requestNumber => bytes32 _id) public nonceToRequestId;
mapping(uint256 _nonce => bytes32 _requestId) public nonceToRequestId;

/// @inheritdoc IOracle
mapping(bytes32 _requestId => bytes32 _finalizedResponseId) public finalizedResponseId;
Expand Down
Loading